feat: use modfile package to write modfile
#1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
harry-hov
commented
Aug 28, 2023
moul
reviewed
Aug 31, 2023
moul
approved these changes
Aug 31, 2023
3 tasks
zivkovicmilos
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Essentially the same comment I had about #1078:
#1078 (review)
Please see:
https://app.codecov.io/gh/gnolang/gno/pull/1077
harry-hov
force-pushed
the
hariom/improv-writetopath
branch
from
3fb37ff
to
a6d2dab
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
+ Coverage 47.59% 47.77% +0.17%
==========================================
Files 369 369
Lines 62505 62710 +205
==========================================
+ Hits 29752 29960 +208
+ Misses 30335 30320 -15
- Partials 2418 2430 +12
☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
Oct 5, 2023
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
The previous implementation manually iterates over the `Require` and `Replace` and writes them in the string var to construct the modfile, which is very inefficient and doesn't handles comments and other cases. Changed it use `modfile` package to write modfile(gno.mod/go.mod). It uses `*modfile.FileSyntax`. Copied few methods from `modfile` package to manipulate `*modfile.FileSyntax`. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation manually iterates over the
RequireandReplaceand writes them in the string var to construct the modfile, which is very inefficient and doesn't handles comments and other cases.Changed it use
modfilepackage to write modfile(gno.mod/go.mod). It uses*modfile.FileSyntax. Copied few methods frommodfilepackage to manipulate*modfile.FileSyntax.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description